workflows: Fix gosec errors & enable code annotations
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
refs #9 |
yhabteab
commented
May 27, 2024
| @@ -22,7 +22,7 @@ func (t *TLS) MakeConfig(serverName string) (*tls.Config, error) { | |||
| return nil, nil | |||
| } | |||
|
|
|||
| tlsConfig := &tls.Config{} | |||
| tlsConfig := &tls.Config{MinVersion: tls.VersionTLS12} | |||
There was a problem hiding this comment.
Go redis does the same thing here too.
https://github.com/redis/go-redis/blob/master/options.go#L314-L317
oxzi
reviewed
May 27, 2024
yhabteab
force-pushed
the
enable-annotations
branch
from
7c096b9 to
ff4b912
Compare
oxzi
approved these changes
May 28, 2024
yhabteab
force-pushed
the
enable-annotations
branch
from
ff4b912 to
4003fd8
Compare
oxzi
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables code annotations in case of failures and fixes the actions triggered by the main branch.
https://github.com/Icinga/icinga-go-library/actions/runs/7783022809/job/21220618068
This PR suppresses also some of the reported existing
gosecerrors and solves some of them as well and drops theonly-new-issueflag set for the go linter.