Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tell users how not to use volumes #46

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Conversation

Al2Klimov
Copy link
Member

@Al2Klimov Al2Klimov commented Jan 19, 2021

refs #45

@Al2Klimov Al2Klimov requested a review from N-o-X January 19, 2021 15:32
@mcktr
Copy link
Member

mcktr commented Jan 19, 2021

I strongly disagree on this pull request. This does not fix the problem at all and is from a user perspective a very bad solution, the consequence is that you have to start the container once without any configuration file!

The container already contains a custom build Go entrypoint binary, why not detect programmatically if it is the very first startup or not? If it is the very first startup the Go entrypoint can the create the directories or let the Icinga 2 daemon create the directories.

Best regards
Michael

@Al2Klimov Al2Klimov force-pushed the bugfix/init-volumes-45 branch from ff71990 to cd25f8c Compare January 12, 2022 11:14
@cla-bot cla-bot bot added the cla/signed label Jan 12, 2022
@Al2Klimov Al2Klimov requested review from julianbrost and removed request for N-o-X January 12, 2022 11:14
@julianbrost
Copy link
Contributor

I wouldn't see this PR as a fix for the corresponding issue, but rather a documentation of an unfortunate pitfall with no real solution.

So remove the "fixes" and I'm fine with this for now as it is still better than the status quo and to me there so obvious simple solution to the actual problem (I'll comment more on this in the issue in a second).

@Al2Klimov Al2Klimov requested review from julianbrost and removed request for julianbrost April 25, 2022 09:06
@julianbrost julianbrost merged commit 67233fe into master Apr 25, 2022
@julianbrost julianbrost deleted the bugfix/init-volumes-45 branch April 25, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants