Merge pull request #250 from fl0wx/main

added missing quotes to ticket delegation
Icinga · Dec 31, 2023 · 12c4ac1 · 12c4ac1
2 parents ff0fcfd + bf024ca
commit 12c4ac1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/changelogs/fragments/fix_missing_quotes_delegate_ticket.yml b/changelogs/fragments/fix_missing_quotes_delegate_ticket.yml
@@ -0,0 +1,3 @@
+---
+bugfixes:
+  - "icinga2 feature api: fixed missing quotes in delegate ticket command for satellites or second master nodes."
diff --git a/roles/icinga2/tasks/features/api.yml b/roles/icinga2/tasks/features/api.yml
@@ -136,7 +136,7 @@
         {% if icinga2_ca_host != 'none' %} --cert "{{ icinga2_cert_path }}/{{ icinga2_cert_name }}.crt" {% else %} --csr "{{ icinga2_cert_path }}/{{ icinga2_cert_name }}.csr" {%- endif %}
 
     - name: delegate ticket request to master
-      shell: icinga2 pki ticket --cn "{{ icinga2_cert_name }}{% if icinga2_ticket_salt is defined %} --salt {{ icinga2_ticket_salt }}{% endif %}"
+      shell: icinga2 pki ticket --cn "{{ icinga2_cert_name }}" {% if icinga2_ticket_salt is defined %} --salt "{{ icinga2_ticket_salt }}"{% endif %}
       delegate_to: "{{ icinga2_delegate_host | default(icinga2_ca_host) }}"
       register: icinga2_ticket
       when: icinga2_ca_host != 'none'