-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: 🐛 Clean removal of output files #6986
base: master
Are you sure you want to change the base?
WIP: 🐛 Clean removal of output files #6986
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6986 +/- ##
==========================================
- Coverage 85.61% 77.49% -8.13%
==========================================
Files 1621 649 -972
Lines 63993 31679 -32314
Branches 2035 262 -1773
==========================================
- Hits 54789 24550 -30239
+ Misses 8871 7069 -1802
+ Partials 333 60 -273
Continue to review full report in Codecov by Sentry.
|
Quality Gate passedIssues Measures |
The issue is that we have 2 separate services ( |
What do these changes do?
TL;DR: Removing (output) files referenced by Nodes, leaves the system in an inconsistent state.
Currently, the WebServer is the 1st responder and forwards the deletion requests to the Storage service, which deletes physically the file(s).
The Projects/Nodes are not updated accordingly and director v2 is not informed about the changes.
Related issue/s
How to test
Dev-ops checklist