🐛 ✨ Check #credits >= 0.0 before returning solver job outputs

[bisgaard-itis]

What do these changes do?

• Check number of credits is non-negative before returning outputs of solver job in the api-server
• Fix bug with swagger api in webserver

Related issue/s

• resolves Check #credits > 0 before returning solver outputs from api-server #5236

How to test

Dev Checklist

• No ENV changes or I properly updated ENV (read the instruction)

DevOps Checklist

[codecov]

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (eaff29d) 87.3% compared to head (92f135d) 87.2%.

Additional details and impacted files

@@           Coverage Diff            @@
##           master   #5249     +/-   ##
========================================
- Coverage    87.3%   87.2%   -0.1%     
========================================
  Files        1302    1260     -42     
  Lines       53251   52053   -1198     
  Branches     1167    1167             
========================================
- Hits        46496   45408   -1088     
+ Misses       6506    6396    -110     
  Partials      249     249             

Flag	Coverage Δ
integrationtests	65.0% <ø> (+<0.1%)	⬆️
unittests	85.0% <74.5%> (-0.2%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...src/simcore_service_api_server/core/application.py	97.5% <100.0%> (+<0.1%)	⬆️
...c/simcore_service_api_server/services/webserver.py	90.8% <100.0%> (+0.3%)	⬆️
...simcore_service_webserver/products/_middlewares.py	100.0% <ø> (ø)
...vice_api_server/api/routes/solvers_jobs_getters.py	92.6% <88.8%> (+11.1%)	⬆️
...imcore_service_api_server/utils/client_base_dev.py	0.0% <0.0%> (ø)
...ore_service_api_server/api/errors/custom_errors.py	75.0% <75.0%> (ø)
...er/src/simcore_service_api_server/core/settings.py	91.2% <44.4%> (-3.5%)	⬇️

... and 46 files with indirect coverage changes

[matusdrobuliak66]

Cool thanks! Q: so what was th e problem with not able to query the products API?

[bisgaard-itis]

Cool thanks! Q: so what was th e problem with not able to query the products API?
The credentials used to access the webserver from the api-server are the users' and the products endpoint is only accesible for POs. But I was able to use another endpoint which is accessible to users.

[mrnicegyu11]

thx!

[GitHK]

👍

[sanderegg]

nice. you should probably be careful with the auto-import functionality in vscode. this always imports with absolute import instead of relative if the file is not imported yet.
Then you get issues with Ruff vs iSort

[pcrespov]

Cool! I left some suggestions and questions

[pcrespov]

Thx. Added some extra comments regarding the error msgs

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud