Refactor: 매소드 네이밍 정리 및 웹소켓 핸들러 코드 최적화 #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- MyPageController ~ SocketController
…o refactor/method-name-0501
- SocketService, Socket 접속 관련
- 메소드 네이밍 리팩토링 - dto record 자료형으로 변경
…refactor/method-name-0501
Youthhing
reviewed
May 6, 2024
| @@ -15,7 +15,7 @@ public enum ErrorCode { | |||
| FILTER_EXCEPTION(HttpStatus.UNAUTHORIZED, "필터 내부에러 발생"), | |||
| JWT_FORM_ERROR(HttpStatus.UNAUTHORIZED, "jwt 형식 에러 발생"), | |||
|
|
|||
| EMAIL_NOT_FOUND(HttpStatus.NOT_FOUND, "해당 이메일이 존재하지 않습니다."), | |||
There was a problem hiding this comment.
해당 EMAIL_NOT_FOUND 에러는 여러곳에서 사용되고 있어서 소켓 핸들러에서 Enum명이 바뀌었다고 다 바꾸면 안됩니다..!
@gikhoon
src/main/java/cotato/csquiz/global/websocket/WebSocketHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/cotato/csquiz/global/websocket/WebSocketHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/cotato/csquiz/global/websocket/WebSocketHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/cotato/csquiz/global/websocket/WebSocketHandler.java
Outdated
Show resolved
Hide resolved
- 별도의 'sendMessage(session, object)' 활용 - 해당 메서드에서 예외 처리 담당
- findOldMembersList -> findOldMembers
gikhoon
approved these changes
May 6, 2024
src/main/java/cotato/csquiz/global/websocket/WebSocketHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/cotato/csquiz/global/websocket/WebSocketHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/cotato/csquiz/global/websocket/WebSocketHandler.java
Outdated
Show resolved
Hide resolved
- findOldMembersList -> findOldMembers
gikhoon
approved these changes
May 6, 2024
Youthhing
reviewed
May 6, 2024
src/main/java/cotato/csquiz/controller/GenerationController.java
Outdated
Show resolved
Hide resolved
Youthhing
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.