Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COT-112] Feature: 랜덤 퀴즈 반환 API 구현 #245

Merged
merged 10 commits into from
Dec 17, 2024

Conversation

gikhoon
Copy link
Member

@gikhoon gikhoon commented Dec 12, 2024

연관된 이슈

이슈링크(url):

✅ 작업 내용

develop 브랜치로 rebase하고 다시 브랜치 올렸습니다

🗣 ️리뷰 요구 사항

@gikhoon gikhoon self-assigned this Dec 12, 2024
@gikhoon gikhoon marked this pull request as ready for review December 12, 2024 10:00
@gikhoon gikhoon requested a review from Youthhing December 12, 2024 10:00
@Youthhing
Copy link
Member

ddf0ff9
414521c

이 두 커밋은 이전 PR 내용 같아요! 리베이스 그냥 Develop 기준으로 하면 우리는 squash 머지라 제대ㅔㅗㄹ 안됩니다

@Youthhing Youthhing force-pushed the feature/COT-112-random-quiz branch from cbf0d18 to d5cb598 Compare December 12, 2024 15:39
@gikhoon gikhoon requested a review from Youthhing December 14, 2024 14:49
@gikhoon gikhoon requested a review from Youthhing December 17, 2024 07:58
@Youthhing Youthhing merged commit 560087e into develop Dec 17, 2024
1 check passed
@Youthhing Youthhing deleted the feature/COT-112-random-quiz branch December 17, 2024 07:58
Youthhing added a commit that referenced this pull request Dec 26, 2024
* [COT-72] Fix: 출결 결과 ENUM 설명 오류 수정 (#216)

* fix: change description of online, offline in attendanceResult

* fix: change attendanceResult status to OFFLINE when attend by offline

* [COT-79] Hotfix: 기수별 출결 기록 카운팅 이슈 해결 (#217)

* [COT-72] Feature: 프로필 링크 관련 테이블 추가 (#209)

* feat: add university, introduction column in member entity

* feat: create profile link entity

* refactor: rename hall of fame service

-> myPageService -> HallOfFameService

* feat: create memberProfile service, repository file

* feat: delete limit of introduction, university column length

* refactor: rollback name of hall of fame service

* feat: add TEXT option in introduction

* refactor: change parameter of hall of fame API

-> accessHeader -> AuthenticationPrincipal

* refactor: delete unused Builder from ProfileLink

* [COT-88] Refactor: 출결 API 필드명 통일 (#220)

* refactor: attendance response field name

* refactor: update attendance required field

* chore: remove unused import line

* [COT-87] Feature: 기수별 활동 부원 목록 추가 (#219)

* refactor: delete unused dependency in memberController

* refactor: delete unused import of GenerationMember Entity

* refactor: change static method name when migrate generationMember

* feat: develop post GenerationMember API

* feat: develop update memberRole of generationMember

* refactor: delete unused Annotation

* style: Remove unnecessary line breaks for code convention

* refactor: delete unused Annotation

* feat: change add generationMember one-by-one to list

* refactor: rename static method

migrate -> of

* refactor: delete Schema tag in request

* feat: change request field format of createGenerationMember

* refactor: rename method name of find members with validation

* refactor: rename method name of find members with validation

* [COT-63] Feature: 세션 추가 시 출결 옵션을 선택할 수 있다. (#221)

* feat: create session type column

* feat: add session type when create session

* feat: create attendance by session type

* feat: add session type field

* feat: add get session type method

* feat: validate dto field

* feat: change offline session validation method

* style: remove end line

* refactor: simplify condition line

* [COT-90] Feature: 기수별 활동 부원 삭제 (#223)

* feat: develop delete generationMember API

* refactor: change way of delete data of generationMember

-> deleteAll -> delete query

* refactor: rename method

* feat: add validation for existence of generationMember ids before deletion

* [COT-91] Feature: 세션 타입에 따른 출결 입력 제한 (#222)

* [COT-65] Feature: 기수별 활동 멤버 목록 반환 API  (#225)

* feat: find generationMemberInfos by generation API

* feat: sort GenerationMemberInfo with member name

* [COT-98] Fix: API 엔드포인트 리소스가 중복되어 내려가는 이슈 수정 (#226)

* [COT-104] Feature: 세션 수정 시 출결 옵션 선택 가능 (#228)

* feat: update session type

* feat: update attendance if not exist

* chore: remove unused import line

* feat: change update api path

* feat: use session reader

* feat: update session

* feat: update attendance deadline

* [COT-113] Feature: 세션 단건 조회 시 출결 필드 반환 (#239)

* feat: add session type field

* chore: add required description

* [COT-108] Refactor: AttendanceAdminService 추상화 (#240)

* refactor: update attendance method

* refactor: move update attendance records

* refactor: move create attendance

* refactor: move get attendance records

* refactor: move get attendance records by attendance

* refactor: change attendance admin service class name

* [COT-106] Feature: 출결 기록 수정 시 세션 타입에 맞는 기록 수정만 가능하다. (#230)

* feat: check session and attendance type when update attendance record

* feat: use session reader

* [COT-111] Feature: 랜덤 퀴즈 테이블 생성 (#232)

* feat: create random quiz table for cs quiz tutorial

* feat: delete column name of embedded field

* feat: add nullable option and enumerated annotation

* refactor: rename choices field name

* refactor: rename description of QuizCategory

* feat: add quizCategory

* feat: add quizCategory

* refactor: reorder category

* [COT-89] Feature: 세션 수정 시 비관적 X-Lock 생성 (#243)

* feat: add pessimistic x-lock while finding session by id

* feat: add pessimistic x-lock while finding attendance by sessionId

* feat: add validation of attendance time while updating session

* Revert "feat: add validation of attendance time while updating session"

This reverts commit 6fad4df.

* style: remove unnecessary line

* feat: add read only transaction in select jpql

* [COT-112] Feature: 랜덤 퀴즈 반환 API 구현 (#245)

* feat: create random quiz response data

* feat: get random quiz for visitor

* refactor: move building choice list method to choices class

* style: remove unused import

* feat: add answerNumber field in tutorial quiz response

* refactor: rename getChoices List method

* feat: change random quiz api name

* feat: change api name of spring security

* feat: delete answer info field in tutorialQuiz response

* refactor: move getChoices and imageUrl method  to randomQuiz entity

* [COT-115] Feature: 문제 풀이 신호 비동기 전송 처리 (#248)

* feat: start and access quiz with async

* chore: log disconnected user id when access and start quiz

* [COT-114] Feature: 세션 수정 시 출석시간 유효성 검사 (#244)

* [COT-119] Chore: PR Template 변경 (#249)

* [COT-123] Feature: 출석 단건 조회에 세션 타입 추가 및 기수별 목록 조회에 openStatus 제거 (#251)

* feat: 세션 단건 조회에 세션 타입 추가

* chore: map 네이밍 컨벤션

* feat: 출석에 세션이 존재하지 않는 경우 예외 발생

* feat: 기수별 출결 목록에 openStatus 필드 제거

* [COT-118] Feature: 랜덤 퀴즈 제출 API 구현 (#246)

* feat: develop reply to randomQuiz API

* style: rename parameter

quizId -> randomQuizId

* refactor: change RandomQuiz reply API from POST to GET

* refactor: change type of randomquiz result

* refactor: change type of quiz result

* refactor: change api path

* Revert "refactor: change type of quiz result"

This reverts commit fe14323.

---------

Co-authored-by: GiHun Nam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants