Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COT-61] Feature: 출결 시간 타입 변경 #205

Merged
merged 6 commits into from
Nov 19, 2024

Conversation

gikhoon
Copy link
Member

@gikhoon gikhoon commented Nov 18, 2024

연관된 이슈

이슈링크(url):

✅ 작업 내용

  • 출결 시간 반환 DTO 타입 변경

  • AddSession, UpdateSession 시 출결 마감, 지각 마감 시간 타입 변경

  • LocalTime -> LocalDateTime

🗣 ️리뷰 요구 사항

@gikhoon gikhoon self-assigned this Nov 18, 2024
Copy link
Member

@Youthhing Youthhing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

임베디드 타입으로 쓰지 않는데 AttendanceDeadLineDto가 꼭 필요한지 고민해볼 필요가 있을 것 같아요~

@Youthhing Youthhing merged commit 54c3b3c into develop Nov 19, 2024
1 check passed
@Youthhing Youthhing deleted the feature/COT-61-attendance-time-type branch November 19, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants