Feature#529 #566
Closed
Feature#529 #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented by UserDto. To allow abstraction on service layer in get user by id functionality
Now service and all previous tests works using the IdOnly interface
Replaces UserEmailDto when findByEmail functionality. Better abstraction. Goal: Interface Segregation
Now service's publics methods only accepts interfaces, these provides only the minimum data needed for the method
TODO: fix tests
Only implemented 2 new tests in UserDtoTest, the others upgrated
DRY on tests + builder in UserDto
inhertited included, only left wildcard on add user resource
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
done and all previous tests passed.
Notice for futures TODO:
There were many endpoints and use case in user management not tested when this task was started.
If you want just reject the PR and I will do it.
Intergation test:
GET endpoints no tested
POST user not tested when duplicated email
Controller unit test:
GET enpoints not tested when not found (email + id)
POST user not tested when duplicated email or max limit reached