This repository has been archived by the owner on Sep 14, 2019. It is now read-only.
Fixed upstream broker connection problem #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…handshake response
akawamura
pushed a commit
that referenced
this pull request
Sep 28, 2018
…remove (EAF-667) Added dslink_save_nodes, dslink_load_nodes and dslink_remov…
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the upstream handshake http request the current implementation cannot handle the response being sliced into multiple network packages. The socket to read from is still configured in NONBLOCKING mode (required for use with libuv). But this may lead to a EWOULDBLOCK error result after reading just part of the response message. To fix this we need to set the socket back to blocking mode.
Additionally the EINTR error result is not handled correctly (retry).