Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlueROV2 Models #21

Merged
merged 11 commits into from
Oct 23, 2024
Merged

BlueROV2 Models #21

merged 11 commits into from
Oct 23, 2024

Conversation

rakeshv24
Copy link
Collaborator

@rakeshv24 rakeshv24 commented Oct 11, 2024

This PR introduces the following changes:

  1. Inclusion of BlueROV2 models with the necessary plugins.
  2. Addition of the underwater camera plugin to all robot models.
  3. Creation of a robot_config.py file for each robot to configure ros_gz_bridge and launch any other dependencies alongside it.
  • Launching BlueROV2 in dave_ocean_waves.world:
colcon build && source install/setup.bash

ros2 launch dave_demos dave_robot.launch.py z:=-5 namespace:=bluerov2 world_name:=dave_ocean_waves paused:=false
  • Launching BlueROV2 Heavy in dave_ocean_waves.world:
colcon build && source install/setup.bash

ros2 launch dave_demos dave_robot.launch.py z:=-5 namespace:=bluerov2_heavy world_name:=dave_ocean_waves paused:=false

@woensug-choi
Copy link

woensug-choi commented Oct 17, 2024

image

@rakeshv24

  • I see axis arrow on the BlueROV2 Heavy. Quick fix would be lowering the position of the camera?
  • I thought by setting the <clip> 10 meter max would not show the sky in the camera but it does. Can we solve this? (pessimistic)

@rakeshv24
Copy link
Collaborator Author

@woensug-choi

  1. The axes will be visible with any robot model because it is included as an element in the world file ( https://fuel.gazebosim.org/1.0/hmoyen/models/North East Down frame). I think the better solution would be to remove it from the world files. What are your thoughts on this?
  2. The clipping functionality works as intended. Below are a few examples with the camera pitched down:
  • with far clipping of 10m:
    Screenshot from 2024-10-22 15-11-35

  • with far clipping of 100m:
    Screenshot from 2024-10-22 15-10-44

@woensug-choi
Copy link

woensug-choi commented Oct 23, 2024

@rakeshv24 Goooood to go! I've made update on Wiki Documents.

@rakeshv24 rakeshv24 merged commit 105fa19 into ros2 Oct 23, 2024
1 check passed
@rakeshv24 rakeshv24 deleted the robot_launch branch October 23, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants