-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSOC-87] Robot models with sensor plugins #16
Conversation
# Include the Rexrov launch file if the namespace is "rexrov" | ||
rexrov_launch = IncludeLaunchDescription( | ||
PythonLaunchDescriptionSource( | ||
PathJoinSubstitution( | ||
[FindPackageShare("dave_robot_models"), "launch", "rexrov.launch.py"] | ||
) | ||
), | ||
condition=IfCondition(EqualsSubstitution(namespace, "rexrov")), | ||
) | ||
|
||
# Include the Glider launch file if the namespace is "glider_slocum" | ||
glider_launch = IncludeLaunchDescription( | ||
PythonLaunchDescriptionSource( | ||
PathJoinSubstitution( | ||
[ | ||
FindPackageShare("dave_robot_models"), | ||
"launch", | ||
"glider_slocum.launch.py", | ||
] | ||
) | ||
), | ||
condition=IfCondition(EqualsSubstitution(namespace, "glider_slocum")), | ||
) | ||
|
||
include = [rexrov_launch, glider_launch] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rakeshv24 Could we have those ros_gz_bridge
launch files in the each robot's description folder along with the model.sdf
? I think those ros_gz configurations are more like descriptions for each robot
Example structure:
- dave_robot_models
- description
- glider_slocum
- model.sdf
ros_gz_bridge.py
- rexrov
- model.sdf
ros_gz_bridge.py
- glider_slocum
- description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way, we don't need IfCondition
and keep upload_robot.launch.py
unchanged when adding new robots
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure that is a good idea. Let me try that out!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@woensug-choi but how do we invoke those ros_gz_bridge.py
files? Don't we still need to use the IfCondition
for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rakeshv24 something like this?
ros_gz_bridge = [IncludeLaunchDescription(
PythonLaunchDescriptionSource(
PathJoinSubstitution(
[
FindPackageShare("dave_robot_models"),
"description",
namespace,
"ros_gz_bridge.py",
]
)
),
)]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
5de9230
to
92fa2b4
Compare
92fa2b4
to
98d4849
Compare
92fa2b4
to
98d4849
Compare
92fa2b4
to
fc2882d
Compare
This PR includes the following updates:
rexrov
andglider_slocum
models.ros_gz_bridge
node properly.dave_robot_launch
package withdave_demos
for generality.Documentation: Link