FIX Several small fixes #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturoAmorQ
changed the title
ogrisel
reviewed
Jul 2, 2024
ArturoAmorQ
changed the title
added 2 commits
September 19, 2024 10:22
ArturoAmorQ
commented
Sep 19, 2024
ogrisel
approved these changes
Nov 22, 2024
|
@ArturoAmorQ I finally answered your feedback in #780 (comment). |
Co-authored-by: Olivier Grisel <[email protected]>
ArturoAmorQ
commented
Nov 25, 2024
|
Thanks for the review @ogrisel. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the end of the First look at the dataset notebook, under the heading "we made important observations" we mention that linear models can only capture linear interactions but there is no prior reference to linear models.
The word "complex" at the end of the Effect of the sample size in cross-validation notebook may be misleading. Here we don’t mean complexity as in the depth of a decision tree or the degree of a polynomial (which indeed would lead to overfitting), but rather that a more "expressive" model should be used.
In the Solution for Exercise M3.02 the wording refers to the "accuracy of the model" but the model is a
KNeighborsRegressor.The
value_countsfunction in the Classification metrics notebook is raising a warning.This PR proposes some fixes to address those issues.