ENH Rework narrative of GBDT notebook #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
reviewed
Apr 26, 2024
|
|
||
| # %% | ||
| import pandas as pd | ||
| import numpy as np | ||
|
|
||
| # Create a random number generator that will be used to set the randomness | ||
| rng = np.random.RandomState(0) | ||
| rng = np.random.RandomState(0) # Create a random number generator |
There was a problem hiding this comment.
Let's move the generator next to the data generation. We should avoid showing a pattern where people would use the generator across different function and estimators.
So the best practice is just to show it next to the data generation. we could even slightly change the code and have:
def generate_data(n_samples=50, seed=0):
rng = np.random.default_rng(seed)
x = rng.normal(size=(n_samples,)) * ...
noise = rng.normal(size=(s_samples,)) * 0.3using default_rng should be encourage nowadays.
github-actions bot
pushed a commit
that referenced
this pull request
May 17, 2024
Co-authored-by: ArturoAmorQ <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]> 31bfaaf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally I wanted to rework only the wording, as well explaining the GBDT algo is the cornerstone for understanding HGBT. But then I decided to factorize the code by introducing a helper function to keep the focus on the narrative other than the code.