Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

project: Update Local Unit edit, validation, and delete workflow #1593

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

project: Update Local Unit edit, validation, and delete workflow #1593

wants to merge 13 commits into from

Conversation

shreeyash07
Copy link
Collaborator

@shreeyash07 shreeyash07 commented Dec 19, 2024 •
edited
Loading

Addresses:

Depends

IFRCGo/go-api#2346

Changes

  • Show local units form changes in modal
  • Show changes in form fields
  • Add revert button and revert reason, modal and form while validating
  • Add delete button and delete reason, modal in local unit form and local unit table action

This PR doesn't introduce:

  • typos
  • conflict markers
  • unwanted comments
  • temporary files, auto-generated files or secret keys
  • console.log meant for debugging
  • codegen errors

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1624014

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@shreeyash07 shreeyash07 requested a review from tnagorra December 19, 2024 09:03
@shreeyash07 shreeyash07 requested a review from samshara December 19, 2024 09:03
@shreeyash07 shreeyash07 requested review from frozenhelium and samshara and removed request for samshara December 19, 2024 09:04
shreeyash07 and others added 12 commits December 20, 2024 11:54
@shreeyash07 @samshara
feat(local-units): add delete modal and refine permissions
018605c 
- Add delete modal in Local Units Form and Local Units Table  
- Separate delete and validate permissions for local units  
- Simplify delete permission logic  

Co-authored-by: samshara <[email protected]>
@shreeyash07 @samshara
Add local unit changes modal
a472457 
- Add function to get changes name and value
- Add new file for key and label of the field
@samshara
feat: display updated local units in modal after editing
634e9bb
@samshara
feat(local-units): use translation strings for field names in confirm…
c5046bf 
… changes modal
@samshara
fix: use better naming, improve type
61e36cf
@shreeyash07 @samshara
Add revert changes button in local unit form
4cf4ca5
@shreeyash07 @samshara
Update readOnly logic and set error in revert form
55c5f98
@shreeyash07 @samshara
Add isLocked check for the edit dropdown in table action
2b43ef4
@shreeyash07 @samshara
Show latest form values changes for local unit validation
7c6ef09
@samshara
feat: minor refactor to get changed field value for visibility option
77434c8
@shreeyash07 @samshara
Handle latest changes failure request
19b09a0
@shreeyash07 @samshara
Add new local unit tag in add local unit form modal
08c1d9a
@samshara samshara force-pushed the project/local-unit-v2 branch from 6d24ec0 to 08c1d9a Compare December 20, 2024 06:09
@shreeyash07 @samshara
- Fix changes label
1624014 
- Fix field highlights issue for new local unit
@tnagorra tnagorra changed the title Update Local Unit edit, validation, and delete workflow Project: Update Local Unit edit, validation, and delete workflow Dec 24, 2024
@tnagorra tnagorra changed the title Project: Update Local Unit edit, validation, and delete workflow project: Update Local Unit edit, validation, and delete workflow Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barshathakuri barshathakuri barshathakuri approved these changes

@tnagorra tnagorra Awaiting requested review from tnagorra

@frozenhelium frozenhelium Awaiting requested review from frozenhelium

@samshara samshara Awaiting requested review from samshara

Assignees

@samshara samshara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shreeyash07 @barshathakuri @samshara