Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/subscription improvements #105

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

barshathakuri
Copy link
Contributor

Addresses

  • #example-issue-number

Depends on

  • #example-Issue/PR-number

NOTE: Mention related users here if any.

Changes

  • Add email templates

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

thenav56 and others added 2 commits December 3, 2024 23:14
- Add helper script to create fake alerts
- Remove legacy templates
- Add helper dev views to update templates
@thenav56 thenav56 changed the base branch from develop to project/phase-2 December 4, 2024 14:31
- Truncate alert admins to 40 chars
- Update TODOs
- Upgrade pyright
@thenav56 thenav56 merged commit 26ecce3 into project/phase-2 Dec 4, 2024
3 checks passed
@thenav56 thenav56 deleted the feature/subscription-improvements branch December 4, 2024 15:27
thenav56 added a commit that referenced this pull request Dec 5, 2024
* Update subscriptions email template

- Add helper script to create fake alerts
- Remove legacy templates
- Add helper dev views to update templates

* Fix email templates

* Fix email raw text templates

- Truncate alert admins to 40 chars

* Add error catch

- Update TODOs
- Upgrade pyright

---------

Co-authored-by: thenav56 <[email protected]>
thenav56 added a commit that referenced this pull request Dec 6, 2024
* Update subscriptions email template

- Add helper script to create fake alerts
- Remove legacy templates
- Add helper dev views to update templates

* Fix email templates

* Fix email raw text templates

- Truncate alert admins to 40 chars

* Add error catch

- Update TODOs
- Upgrade pyright

---------

Co-authored-by: thenav56 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants