Weight Initialization, GNum class and NFData instances #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I'll get round to this soon. |
|
No worries, it took me quite some time as well. Btw, I checked the implemented learning algorithm and it seems to me that this is SGD with momentum and regularization. Is this correct? |
HuwCampbell
reviewed
Sep 11, 2018
HuwCampbell
reviewed
Sep 11, 2018
| -- | Class for random initialization of a layer. This enables to use | ||
| -- various initialization techniques for the networks. Every layer | ||
| -- needs to implement this. | ||
| class RandomLayer x where |
There was a problem hiding this comment.
Does pulling this into a separate class buy us anything?
Maybe UpdateLayer should just be renamed to BaseLayer or something and hold both?
There was a problem hiding this comment.
Yes, I wanted to keep UpdateLayer for backward compatibility. But renaming is fine as well. I am currently on vacation and look into the other issues soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #51