Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8주차] cow mvc practice(BaekJaehyuk) #3
base: main
Are you sure you want to change the base?
[8주차] cow mvc practice(BaekJaehyuk) #3
Changes from 6 commits
7f0c516
226fb3d
b0411c1
1b24ae7
4cf9ed0
bbba0f0
8630525
2d1fb0d
9056ddc
f6768f1
46971e6
727b0d6
1e9a197
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
사용 안하시고 계신데 toEntity를 만들어 놓은 이유가 있을까요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hoya324 호야씨가 만들어 놓으셨어요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
사용하셔야죠
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
댓글을 생성하는 response? 라는 생각이 들어서 프론트에게 Comment 생성에 대한 정보를 넘겨줘야하는가? 라는 생각이 들게 됩니다! 만약 Comment 생성한 후 정보를 반환하고 싶은거라면 CommentResponse 또는CreatedCommnetReponse 와 같은 클래스 명을 사용할거 같아요! 반환의 이유가 있는지 확인해보고 결정해주세요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고민해 보겠습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
id를 Long type으로 설정한 이유가 있나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
경험상 uuid를 사용하는게 좋을 때도 많아서 한번쯤 알아두면 좋을거 같습니다
uuid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Transactional을 interface에도 달고 구현체에도 달게 되면 어떻게 될까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment 객체를 만들때 연관관계 주입을 해주지 않고, 따로 편의 메소드로 작성하는 것이 좋을 것 같습니다.(post,member)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CraeteCommentRequest의 toEntity메소드를 사용하여 인스턴스 생성하는 것이 더 좋아보입니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
연관관계 편의 메소드를 만들어 한번에 관리해주세요