Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elixir-ls 0.9.0 (new formula) #91820

Closed
wants to merge 2 commits into from
Closed

elixir-ls 0.9.0 (new formula) #91820

wants to merge 2 commits into from

Conversation

DaniruKun
Copy link
Contributor

@DaniruKun DaniruKun commented Dec 21, 2021

Adding a new formula for the Elixir Language Server. It is a code
intelligence server and debugger implementing the LSP and DAP.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@BrewTestBot BrewTestBot added the new formula PR adds a new formula to Homebrew/homebrew-core label Dec 21, 2021
@DaniruKun
Copy link
Contributor Author

Closes elixir-lsp/elixir-ls#617

chenrui333
chenrui333 previously approved these changes Dec 21, 2021
Formula/elixir-ls.rb Outdated Show resolved Hide resolved
@chenrui333 chenrui333 dismissed their stale review December 21, 2021 23:01

need better test

Formula/elixir-ls.rb Outdated Show resolved Hide resolved
Formula/elixir-ls.rb Outdated Show resolved Hide resolved
@DaniruKun DaniruKun requested a review from carlocab December 30, 2021 09:39
Formula/elixir-ls.rb Outdated Show resolved Hide resolved
Formula/elixir-ls.rb Outdated Show resolved Hide resolved
@DaniruKun
Copy link
Contributor Author

DaniruKun commented Dec 30, 2021

Hmm I also have an issue with the audit not passing: https://github.com/Homebrew/homebrew-core/runs/4667122310?check_suite_focus=true#step:6:33

The reason for this is the .ez archives that are required by the scripts and have to be in the same directory. Can this be ignored, or is there an elegant way to get around this?

@SMillerDev
Copy link
Member

Those shouldn't be in the bin directory though, they should only be in libexec. Only executables like shell scripts should be in bin

@DaniruKun
Copy link
Contributor Author

DaniruKun commented Dec 30, 2021

Those shouldn't be in the bin directory though, they should only be in libexec. Only executables like shell scripts should be in bin

Sorry I phrased it a bit wrong - my issue is that the scripts (e.g. *.sh) have to be in the same directory as the .ez archives for the app to work.

@SMillerDev
Copy link
Member

Sorry I phrased it a bit wrong - my issue is that the scripts (e.g. *.sh) have to be in the same directory as the .ez archives for the app to work.

In that case installing everything to libexec and using bin.install_symlink libexec/"launch.sh" => "launch-elixir-ls" or a similar naming would be good, that also resolves the comment from Carlo above. You can then use launch-elixir-ls in the test to run launch.sh

@DaniruKun DaniruKun requested a review from SMillerDev January 2, 2022 16:57
Formula/elixir-ls.rb Outdated Show resolved Hide resolved
Adding a new formula for the Elixir Language Server. It is a code
intelligence server and debugger implementing the LSP and DAP.
@DaniruKun DaniruKun requested a review from SMillerDev January 5, 2022 19:23
Formula/elixir-ls.rb Outdated Show resolved Hide resolved
@DaniruKun DaniruKun requested a review from SMillerDev January 17, 2022 21:59
Formula/elixir-ls.rb Outdated Show resolved Hide resolved
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DaniruKun ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

@BrewTestBot
Copy link
Member

:shipit: @SMillerDev has triggered a merge.

@DaniruKun
Copy link
Contributor Author

Thanks for your support guys ❤️

@megalithic
Copy link

❤️ well done @DaniruKun !!!!

@github-actions github-actions bot added the outdated PR was locked due to age label Feb 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants