-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflows/triage: add linux-only label #64294
Conversation
95e84bc
to
16151a1
Compare
This should also behave as a |
I don't think it's a good idea to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 to linux-only
label, agreed about not having a do not merge
yet.
I am ok for a
They are tested, but in linuxbrew-core. Ideally one would first open a PR in linuxbrew-core, check if everything is fine, and then backport the change here. This situation will last until we have merged both repositories: we made huge progress but there are still a lot of things to finish. |
IMHO that's an unworkable situation. I'd say we need to test it here, or not have it here at all. Otherwise it's a ton of work for everyone. |
Do you have a (very) rough time estimate? |
The other strategy was to migrate all the linux changes to this repo in one huge PR, when we are ready. But this also means reviewing a PR that will contain more than 2000 formula changes, and this PR will be an endless moving target. I prefer to add things here slowly, with the risk that some formulae are tested on Linux only with a delay. That does not change much to the current situation where homebrew-core formulae are only tested on Linux when we merge it to linuxbrew-core. The idea is that the changes we make to the homebrew-core repo:
|
6 months? 1 year? It depends on how much help I get to migrate everything. I'll do a status update on Homebrew/brew#7028 soon. |
Is there really no way to properly test this in core on both platforms? Maybe a migration "per family" as we would do with things like Python is the way to go here? I'd love to help, but it's hard to keep track of the status for me. |
Thanks, that's helpful. Given that:
I think the level of testing done here should be ramped up. It may not be feasible to do reverse dependency checking (although it's probably a good idea, IMO) but we could at least be creating and testing bottles without upload. |
Agreed. I think reverse dependency checking only happens for formulae with a bottle on Linux, as we did not bottle everything until now. What I would like is to slowly introduce linux CI for a few "main" formuale in homebrew-core in the next months, to make sure these do not get broken by updates. I am thinking about things like gcc, pkg-config, openssl, unzip, perl, python ...
Can this PR be changed to add just the first label. After some thoughts: I am totally fine that things get bumped here, I was just surprised because I did not think it would happen. But it is just the logical thing to do. We will monitor breakages in linuxbrew-core after merges, like we do for all the other packages. Nothing really changed in the process. |
Just wondering, what's stopping us from already bottling the formula we have migrated here? That seems like the easiest thing. That way you "actually" migrate them rather than upstreaming the changes. |
We could, if it is acceptable to build bottles in this repo, step-by-step. I'll write some stuff about this in Homebrew/brew#7028 then, as there are a few things to be discussed before we do that, and I do not want to hijack this PR for this discussion. |
I'd say we should make bottles here if we can. That's the end goal anyway. |
Cool. Let's discuss this in Homebrew/brew#7028 for the practical details For this PR: we would like to have only the |
201bc94
to
16151a1
Compare
Thanks all for the input! |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?This allows us to quickly identify bump PRs as updates to Linux formulae, which for the time being, should not be updated in
homebrew-core
; see #64175 (comment)