Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pistache 0.4.25 (new formula) #202108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dgreatwood
Copy link

Adding Pistache to homebrew-core for the first time.

Pistache is a modern, fast, elegant HTTP + REST C++17 framework with a pleasant API. It supports Linux (including via Debian - https://packages.debian.org/sid/libpistache-dev), macOS, Windows and BSD.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Adding Pistache to homebrew-core for the first time. Pistache is a
modern, fast, elegant HTTP and REST C++17 framework with a pleasant
API. It supports Linux (including via Debian -
https://packages.debian.org/sid/libpistache-dev), macOS, Windows and
BSD.
@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Dec 22, 2024
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@dgreatwood
Copy link
Author

Looks like there is an error in linuxbrew case, missing libcurl dependency, I'll address and retest. Please standby for now. Thx.

Comment on lines +1 to +6
#
# SPDX-FileCopyrightText: 2024 Duncan Greatwood
#
# SPDX-License-Identifier: Apache-2.0
#

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#
# SPDX-FileCopyrightText: 2024 Duncan Greatwood
#
# SPDX-License-Identifier: Apache-2.0
#

@chenrui333
Copy link
Member

Looks like there is an error in linuxbrew case, missing libcurl dependency, I'll address and retest. Please standby for now. Thx.

you can add uses_from_macos "curl"


def install
system "meson", "setup", "build",
"--buildtype=release",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is part of the standard arguments already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants