-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shell completion for zsh #1166 #1216
Conversation
e967a86
to
eb3422c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Can you split the completions and dump selection into separate PRs? Thanks!
.gitignore
Outdated
.vscode | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.vscode | |
.vscode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MikeMcQuaid done:)
This PR contains only zsh-completion script
dump
command logic updated in #1217 and should be reviewed and merged after this PR, thanks:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work so far!
|
||
_brew_bundle_install() { | ||
_arguments \ | ||
'--file[read the Brewfile from this location. Use --file=- to pipe to stdin/stdout]' \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there's any way to rely on any of the Homebrew/brew code to autogenerate some/all of this or at least have CI to ensure it's kept in sync?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't research that :c
I know there are some tools to automate this script creation in golang, but not sure for ruby
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, I'll try to help! Check out:
and
which you could maybe use for auto-generation?
Don't worry if you can't handle the e.g. GitHub Actions side: I can help with all that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, i'm not good at ruby (actually, it's my first try), but after some research of given code, i think i can make similar for brew bundle
.
It requires some refactoring and i think, i would make it, if may
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tony-sol just wanted to check how things are going and what you're thinking! Thanks again for the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MikeMcQuaid sorry, i've been unlucky with free time lately :c
i remember about this PR, but can't say, when could continue work on it :c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tony-sol No worries! Just saw the rebase and wanted to check!
96bbff1
to
b7b378a
Compare
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
@MikeMcQuaid Would it be acceptable to accept this without the autogen and then for someone else revisit that autogen later? |
@colindean My fear is that without autogen this is going to be a pain to maintain and avoid bitrotting. |
Add
brew bundle
completion for zsh #1166For
bash
/fish
may be added later.