Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/vendor-install: don't silence stderr #16307

Merged
merged 1 commit into from
Dec 11, 2023
Merged

cmd/vendor-install: don't silence stderr #16307

merged 1 commit into from
Dec 11, 2023

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Dec 8, 2023

ruby --version doesn't usually print to stderr. If it does, something's probably wrong.

It's probably more beneficial to us to allow stderr to print so any user reports will have that information.

@Bo98 Bo98 marked this pull request as ready for review December 8, 2023 00:16
MikeMcQuaid
MikeMcQuaid approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks @Bo98!

@MikeMcQuaid MikeMcQuaid merged commit cf86812 into Homebrew:master Dec 11, 2023
26 checks passed
@Bo98 Bo98 deleted the no-stderr-silence branch December 11, 2023 15:45
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bo98 @MikeMcQuaid