Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-cmd/determine-test-runner: add --all-supported #16227

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Nov 17, 2023

Add --all-supported to brew determine-test-runner that makes it output all supported macOS runners (+ Linux if HOMEBREW_LINUX_RUNNER is set) rather than basing it on a supplied formula list. It is mutually exclusive to supplying a list of formulae.

Modify brew doctor workflow to use it.

Also:

  • Supply a minimum macOS bound for GitHub-hosted runners, as they don't necessarily have the same support period as us.
  • Fix arm64 timeouts when HOMEBREW_MACOS_BUILD_ON_GITHUB_RUNNER is set
  • Simplify --eval-all handling since the CLI parser can make it required for us rather than needing a custom odie.
  • Adjust some types (no more nilable arrays)

@Bo98 Bo98 force-pushed the determine-all-runners branch from 2ffade2 to 57a5a62 Compare November 17, 2023 01:53
KingSkybax

This comment was marked as spam.

@Bo98 Bo98 force-pushed the determine-all-runners branch from 57a5a62 to 508fc2a Compare November 17, 2023 02:11
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks @Bo98!

@MikeMcQuaid MikeMcQuaid merged commit 68c660f into Homebrew:master Nov 17, 2023
35 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants