-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
formula: add keg_only_reason to formula hash #12552
Conversation
Review period will end on 2021-12-14 at 00:00:00 UTC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏻. Would love to get this onto formulae.brew.sh too.
One thought: this feels like the sort of thing where we might want to start outputting the values for different OSs in different hashes (so you can get the output for all OSs on a single OS?)
Ah yes we allow Not entirely sure of what the best approach to that will be (short of a full restructure involving breaking changes). Maybe it would be some OS object that specifies key-value overrides/appends to the base JSON. |
This is the one leftover item from the migration in Homebrew/formulae.brew.sh#566: the JSON API only supplies Mac-specific values, since that's the machine that generates the JSON files. First step would be giving A few examples of platform-specific values: |
Review period ended. |
Merged to make clear I think this approach as-is is fine for now 👍🏻
Yeh, I think it's fine to continue this approach for now and extend it with a non-breaking change.
Yup. I'd suggest something like a |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?For inclusion in the JSON API.