Move url2name to formula_creator.rb

Per review comments

Library/Homebrew/dev-cmd/create.rb

@@ -69,25 +69,6 @@ def create_args
     end
   end
 
-  def url2name(url)
-    odebug "url: #{url}"
-    stem = Pathname.new(url).stem
-    odebug "stem: #{stem}"
-    # special cases first
-    name = if stem.start_with? "index.cgi"
-      # http://www.codesrc.com/gitweb/index.cgi?p=libzipper.git;a=summary
-      # https://github.com/Homebrew/brew/pull/9459
-      stem.rpartition("=").last
-    elsif url =~ %r{github\.com/\S+/(\S+)/(archive|releases)/}
-      Regexp.last_match(1)
-    else
-      pathver = Version.parse(stem).to_s
-      stem.sub(/[-_.]?#{Regexp.escape(pathver)}$/, "")
-    end
-    odebug "url2name: #{name}"
-    name
-  end
-
   # Create a formula from a tarball URL.
   def create
     args = create_args.parse

Library/Homebrew/formula_creator.rb

@@ -5,6 +5,27 @@
 require "erb"
 
 module Homebrew
+  module_function
+
+  def url2name(url)
+    odebug "url: #{url}"
+    stem = Pathname.new(url).stem
+    odebug "stem: #{stem}"
+    # special cases first
+    name = if stem.start_with? "index.cgi"
+      # http://www.codesrc.com/gitweb/index.cgi?p=libzipper.git;a=summary
+      # https://github.com/Homebrew/brew/pull/9459
+      stem.rpartition("=").last
+    elsif url =~ %r{github\.com/\S+/(\S+)/(archive|releases)/}
+      Regexp.last_match(1)
+    else
+      pathver = Version.parse(stem).to_s
+      stem.sub(/[-_.]?#{Regexp.escape(pathver)}$/, "")
+    end
+    odebug "url2name: #{name}"
+    name
+  end
+
   # Class for generating a formula from a template.
   #
   # @api private

Library/Homebrew/test/dev-cmd/create_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require "cmd/shared_examples/args_parse"
-require "dev-cmd/create"
+require "formula_creator"
 
 describe "brew create" do
   let(:url) { "file://#{TEST_FIXTURE_DIR}/tarballs/testball-0.1.tbz" }