PDB Serialization Pt. 4, add reexport-pdb command #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add conditional padding to ColumnEntry
Co-authored-by: Swiftb0y <[email protected]>
- add fields to Color struct - add field to PlaylistTreeNode struct - write missing data in Page write_options method
|
Awesome, thanks. I'm currently very busy with work, but I'll have a closer look soon-ish. Also pinging @Swiftb0y :) |
|
Same thing here. I very much appreciate your PR, but I think we should look at #100 first. It would really help if you @erictapen could also do an initial review on that to see if you spot any obvious issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@summersamara and I worked a bit on the issue of PDB serialization. Our efforts are far from being mergeable, but we managed to generate PDB files containing tracks, that can be read by Rekordbox software.
This builds on top of #100.
For easier testing, we introduce the
reexport-pdbcommand, that deserializes an existing PDB file and then serializes the internal representation again. Coming from Rekordbox generated databases this never results in indentical outputs, but we observed the result to be readable by Rekordbox. Also reexporting an already reexported file seems to return an identical file.Originally we wanted to bring our commits in a shape compliant with CONTRIBUTING.md, but never got to it and now I thought it might be better to at least share our efforts for future experimentation than to let our progress bitrot on disk.
Looking forward to your feedback.