Add an 'open' utility to Phoenix #344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On self-hosted installs, several of these apps are not (currently) available, meaning that `get_app()` would fail and we would get null values in the suggested_apps array. Since the `/open_file` API endpoint selects the first result, it could therefore think that there were no available apps, when actually there were. For example, source code files can be opened either in `code` or `editor`. `code` is not available on self-hosted, so the first entry would be null. This change removes that, so `editor` is rightly selected. Also, we have this `file_extension` variable, so let's use it. :^)
`open FILE|URL` opens the given file in the user's preferred app. On Node, we rely on the system's built-in utility rather than attempt to write our own code for figuring out what the preferred application is. On Puter, `puter.ui.launchApp()` can't yet grant access to files, so using `open` on Puter launches the app without the file open. The other issue is that we need to make the app-launching code from the CommandProviders available to coreutils and elsewhere, so that they can interact with stdio without duplicating all the logic.
|
Marking this as ready, but it's still waiting for #481 to be properly useful. |
AtkinsSJ
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.