Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uyghur(China) keyboard, dictionary added. #955

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

neo-turak
Copy link

See the contributing readme for more detailed guideline, please understand and accept them: https://github.com/Helium314/HeliBoard/blob/main/CONTRIBUTING.md
tl;dr (you should still read the full list though):

  • make sure it's wanted
  • a single thing only
  • describe it properly
  • re-use existing mechanisms / code
  • low performance impact
  • make it a draft if you still want to work on it
  • don't do translation PRs

Further

  • When the PR contains "fixes" , the related issue will be linked and automatically closed if the PR is merged (also works for other words like "fix", "resolve", "resolves", "closes", ...)
  • If you add a keyboard layout, make sure you have read https://github.com/Helium314/HeliBoard/blob/main/layouts.md#adding-new-layouts--languages
  • Please avoid force-pushing when doing changes. This way it's not possible which parts have changed since the previous state.

@Helium314
Copy link
Owner

Please do not add dictionaries to this app, I do not accept additiond here to keep app size reasonable.
Dictionaries (with word list) can be added to the dictionaries repository.

Reading the layouts.md file as pointed out in the contribution guidelines would be helpful (e.g. regarding the script)

@Helium314 Helium314 marked this pull request as draft July 23, 2024 20:47
@Helium314
Copy link
Owner

Setting this to draft until necessary changes are done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants