improve inline suggestions

[codokie]

Some password managers like KeepassDX and Bitwarden spam inline suggestion requests (at least in Android 14) so it flickers/disappears whenever a character is typed.

inline-flicker.mp4

This PR attempts to fix this issue to ensure the clipboard suggestions #647 work in tandem with the inline suggestions.
I also changed the expand toolbar key to show a "X" icon that dismisses the inline suggestions and prevent them from reappearing until the input is restarted. So it should also fix #681 as well

[codokie]

@RHJihan it should be possible to dismiss the inline suggestions now. Could you test it on your end?

[RHJihan]

Thanks. Works perfectly. Loved it.

I'm wondering what if someone needs the inline suggestions as well as the toolbar key? As the close button replaces the toolbar key. However, I have not found any case in my mind where this could possibly happen.

[codokie]

Thanks for testing it

I'm wondering what if someone needs the inline suggestions as well as the toolbar key?

If they frequently do that for a specific key then they can pin it.
It now works roughly the same way that Samsung keyboard handles it. If you dont need the suggestions then you would naturally dismiss them.
Once dismissed, inline suggestions may reappear only if the keyboard is reopened (the input is restarted)

[RHJihan]

Could you reproduce the inline suggestion clipping with this PR?
I can't confirm it myself as I don't have access to Android Studio right now. It's an older build with this & other PRs.

[RHJihan]

Samsung Keyboard has this dismiss button there and the inline suggestion is clipped. I don't know, but I thought it might be helpful for this behavior.

[codokie]

@RHJihan I checked and it seems like this empty space appears when no toolbar keys are pinned.
So far I don't think it is caused by the mPinnedKeys view.
The issue also occurs in the latest stable release so it was not introduced by this PR

[codokie]

Actually it is indeed related to the mPinnedKeys view.
I've set that view minWidth to 0dp in the xml and now the empty space is gone when there are no pinned keys.
No adverse effect on the pinned keys as far as I can tell

[RHJihan]

Great! Thanks for fixing this!

[codokie]

This PR needs to adjust to the breaking changes made in #647 and #674.
Unfortunately I won't have the time to do that soon.
I have also stopped using HeliBoard a while back so there is no real incentive for me to test it thoroughly