Fix integer overflows in AssemblyScript & Typescript implementations #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for the PR! |
|
You're right : overflows may produce wrong counts when :
I'll take a look. |
lcallarec
force-pushed
the
fix-integer-overflows
branch
2 times, most recently
from
ea9c823 to
dbe20fe
Compare
lcallarec
force-pushed
the
fix-integer-overflows
branch
from
dbe20fe to
74ebc8b
Compare
|
I guess all remaining overflow issues have been fixed with last commits. |
|
Sorry @MaxGraey, I don't know what happend, looks like I did something that deleted your commit proposal (or there was a github issue) with my comment... I was saying that the bitwise shift operation won't work as is. So I guess that we should write |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
This PR fixes an integer overflow issue in both AssemblyScript & Typescript implementations.
In short : on an
unsigned integer, when overflow occurs, the value won't be read as a negative integer.Please note that in the current implementation, the user could create an Histogram with a signed internal bucket of type
IntXArray; an issue will also occurs and this PR doesn't fix that case. :)Note also that I didn't find a way to test the assembly version in assembly folder : the tested method throws, and it seems that try / catch aren't supported yet