Add tests for data_model_utils.tabular
#470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #470 +/- ##
==========================================
+ Coverage 83.27% 84.36% +1.08%
==========================================
Files 88 88
Lines 4563 4553 -10
Branches 837 830 -7
==========================================
+ Hits 3800 3841 +41
+ Misses 572 525 -47
+ Partials 191 187 -4
|
added 9 commits
June 30, 2020 10:00
|
Feel free to squash commits when merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problems or issues
Is your pull request related to a problem? Please describe.
As reported in #380, we'd like to increase the test coverage.
Currently,
fonduer.utils.data_model_utils.tabularis covered 65.54% (https://codecov.io/gh/HazyResearch/fonduer/src/7f5c6633b51bd2e5102a463c739d6c4ec10db147/src/fonduer/utils/data_model_utils/tabular.py), meaning there is a large space to increase.Does your pull request fix any issue.
Toward #380 .
Description of the proposed changes
Add tests for
data_model_utils.tabularTest plan
This PR adds more tests for
data_model_utils.tabular.Checklist