Fork/alexwenym #38
Merged
Fork/alexwenym #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ounds clipping. Fix spacing.
…on between opposing directions.
Removing unnecessary file
…space for rapidly falling distributions
…luxDistribution class. testing is ongoing
|
There's a whole lot of changes in this branch. I think most of them are good, but it is worth going through them all invidually before we merge it. |
austinschneider
requested changes
Jan 10, 2024
There was a problem hiding this comment.
There are a few minor changes that need to be made before we merge this. Mainly it's removing some comments, a few stray printouts, and deciding if we want to keep some of the files added to resources. There is an issue with how the random numbers are created for the inverse cdf sampling though.
projects/distributions/public/LeptonInjector/distributions/primary/direction/FixedDirection.h
Outdated
Show resolved
Hide resolved
austinschneider
requested changes
Jan 10, 2024
projects/distributions/private/primary/energy/TabulatedFluxDistribution.cxx
Show resolved
Hide resolved
projects/distributions/private/primary/vertex/ColumnDepthPositionDistribution.cxx
Show resolved
Hide resolved
projects/distributions/public/LeptonInjector/distributions/primary/direction/FixedDirection.h
Outdated
Show resolved
Hide resolved
austinschneider
requested changes
Jan 10, 2024
austinschneider
requested changes
Jan 10, 2024
| prob_density /= (M_PI * radius * radius); // (m^-1 * m^-2) -> m^-3 | ||
|
|
||
| @@ -263,7 +265,7 @@ double LeptonProcessWeighter::NormalizedPositionProbability(std::pair<LI::math:: | |||
| record.interaction_vertex[0], | |||
| record.interaction_vertex[1], | |||
| record.interaction_vertex[2]); | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods for sampling tabulated distribution using the inverse CDF method. Fixes a bug with the ATLAS example.