Introduce cime_run(ntsteps), callable for TSMP-PDAF
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove commented out debug output - small style changes with the goal of being close to CIME tag `cime5.6.47`
1. re-introduce `private` statement, this was removed because variables from `cime_comp_mod` had to be used by TSMP-PDAF 2. Add `cime_run` with number of time steps `ntsteps` as input. `ntsteps` is supplied by the TSMP-PDAF interface. 3. Add `stop_alarm` for `cime_run` dependent on `ntsteps`.
|
Draft status: Waiting for testing of corresponding TSMP-PR: HPSCTerrSys/TSMP#229 |
|
I merged #35, which makes the commit history of this PR a bit ugly. After squashing this PR, everything should be in order again! I am now waiting for HPSCTerrSys/TSMP#229. When this TSMP-PR is merged, I think this PR could follow for TSMP2. |
before each forward simulation while-loop. Without this setting, the `ntsteps`-induced `stop_alarm` for the while-loop was not called in a CLM5-PDAF testcase.
|
HPSCTerrSys/TSMP#229 is tested and merged. All changes are under |
kvrigor
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-introduce
privatestatement, this was removed because variables fromcime_comp_modhad to be used by TSMP-PDAFAdd
cime_runwith number of time stepsntstepsas input.ntstepsis supplied by the TSMP-PDAF interface.Add
stop_alarmforcime_rundependent onntsteps.