Fix depends_on setter

CHANGELOG.md

@@ -1,3 +1,6 @@
+### 4.4.0
+* Fix multiple arguments for `depends_on`.
+
 ### 4.3.0
 * Remove the `DependsOn` helper module since it doesn't do anything additive.
 

VERSION

@@ -1 +1 @@
-4.3.0
+4.4.0

lib/buildkite/pipelines/helpers.rb

@@ -6,6 +6,7 @@ module Helpers
       ATTRIBUTE_HELPERS = {
         block: :Block,
         command: :Command,
+        depends_on: :DependsOn,
         key: :Key,
         label: :Label,
         plugins: :Plugins,

lib/buildkite/pipelines/helpers/depends_on.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+module Buildkite
+  module Pipelines
+    module Helpers
+      module DependsOn
+        def depends_on(*values)
+          values.any? ? super(values) : super()
+        end
+      end
+    end
+  end
+end

spec/buildkite/pipelines/helpers/depends_on_spec.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+RSpec.describe Buildkite::Pipelines::Helpers::DependsOn do
+  let(:step_klass) do
+    Class.new do
+      include Buildkite::Pipelines::Attributes
+
+      attribute :depends_on, append: true
+    end
+  end
+
+  let(:step) { step_klass.new }
+
+  describe '#depends_on' do
+    it 'flatterns the value' do
+      step.depends_on([:foo, [:bar, :baz, [:daz]]])
+
+      expect(step.get(:depends_on)).to eq([:foo, :bar, :baz, :daz])
+    end
+
+    it 'allows multiple arguments' do
+      step.depends_on(:foo, :bar, :baz)
+
+      expect(step.get(:depends_on)).to eq([:foo, :bar, :baz])
+    end
+
+    it 'acts as getter when there are no values' do
+      step.depends_on(:foo, :bar, :baz)
+
+      expect(step.depends_on).to eq([:foo, :bar, :baz])
+    end
+  end
+end