Add ability to allow ssh commands only for specific users #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, just wondering if anyone has had a chance to look at this PR in the past few months? |
|
Could you please fix your conflict and I'll review it. Thanks 🙏 |
Signed-off-by: Mario de Frutos <[email protected]>
In Terraform AWS provider vestion 5 the acl option in the aws_s3_object doesn't have default value set to private so we need to add it explicitly Signed-off-by: Mario de Frutos <[email protected]>
thecadams
commented
Jul 25, 2023
| @@ -13,6 +13,7 @@ data "aws_kms_alias" "kms-ebs" { | |||
| } | |||
|
|
|||
| resource "aws_s3_object" "bucket_public_keys_readme" { | |||
| acl = "private" | |||
There was a problem hiding this comment.
Pretty sure this was missing and is needed, but not sure if it belongs in the PR.
|
Hi @Guimove, Thanks for the note. Finally got around to resolving the conflicts, hope it's OK to review, let me know if anything else is needed. Thanks! 🙏 |
|
Hi @Guimove , Any chance you've had a look at this PR yet? Would be great to not have to maintain our fork! Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow only certain users (eg. CI, ansible) to run ssh commands on bastions, rather than blanket allowing all users.