Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added background color and text color to tab label #2236

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

selam
Copy link

@selam selam commented Mar 27, 2024

this patch adds custom background and text color to tabs,

i am not good at gtk library and related tech, i just want to custom colored tabs, instead of label maybe for tab style more good idea to change colors

Copy link
Collaborator

@Davidy22 Davidy22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just on a first impression from building and trying it out, the tabs are visibly compressed horizontally which I'm not quite sure I like, and the tab colors don't fill the full tab which makes it look like weird little flat squares in the middle of each tab. The flat color is a little jarring against the gradients that most themes apply to the tab bar, some transparency in the applied color box might be good. Clicking the cancel button breaks the dialog until the user opens the color picker dialog again.

@selam
Copy link
Author

selam commented Dec 18, 2024

you are right, coloring tabs looks very weird and i suspect themes couse of that, i can't figure out how to fix it, i send this patch as a feature request and a example.

as a web developer i dont have enough experience and knowlage about gtk :(

latest commit fix the usage of cancel button of color picker

@Davidy22
Copy link
Collaborator

Davidy22 commented Dec 19, 2024

I notice in the commit there's some fiddling with dimensions and border being done, can try adjusting that and maybe padding, etc. For working with themes, I did mention earlier you could try making the colors semi-transparent so that they act more like a tint than a solid colored box. Also, would be nice if you could run make check just to make sure tests and formatting stuff is in order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants