unpack: make sure stdout is locked #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #301 +/- ##
==========================================
- Coverage 64.30% 64.26% -0.04%
==========================================
Files 75 75
Lines 5958 5985 +27
Branches 904 904
==========================================
+ Hits 3831 3846 +15
- Misses 1589 1601 +12
Partials 538 538 ☔ View full report in Codecov by Sentry. |
When reading malformed archives, unpack may write error messages to stdout from multiple threads. This can result in interleaved output and garbled messages. To prevent this, a static mutex is added to output functions in common.c.
Gottox
force-pushed
the
fix/unpack-unlocked-stdout
branch
from
fedc8d9 to
00bef59
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading malformed archives, unpack may write error messages to stdout from multiple threads. This can result in interleaved output and garbled messages. To prevent this, a static mutex is added to output functions in common.c.