Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chores: fix 32bit build with -Wconversion #281

Merged
merged 4 commits into from
Aug 12, 2024
Merged

chores: fix 32bit build with -Wconversion #281

merged 4 commits into from
Aug 12, 2024

Conversation

Gottox
Copy link
Owner

@Gottox Gottox commented Aug 12, 2024

Addresses #280

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 73.40426% with 25 lines in your changes missing coverage. Please review.

Project coverage is 64.62%. Comparing base (2566f85) to head (1f59646).

Files Patch % Lines
libsqsh/src/easy/file.c 69.56% 4 Missing and 3 partials ⚠️
libsqsh/src/mapper/mapper.c 50.00% 4 Missing and 1 partial ⚠️
libsqsh/src/file/file_iterator.c 69.23% 4 Missing ⚠️
libsqsh/src/file/file.c 57.14% 2 Missing and 1 partial ⚠️
libsqsh/src/mapper/map_slice.c 50.00% 1 Missing and 1 partial ⚠️
tools/src/stat.c 0.00% 2 Missing ⚠️
libsqsh/src/archive/trailing_context.c 0.00% 1 Missing ⚠️
libsqsh/src/table/export_table.c 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
- Coverage   64.75%   64.62%   -0.13%     
==========================================
  Files          74       74              
  Lines        5541     5578      +37     
  Branches      833      840       +7     
==========================================
+ Hits         3588     3605      +17     
- Misses       1471     1485      +14     
- Partials      482      488       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gottox Gottox force-pushed the fix/32bit-build branch 7 times, most recently from 718ebc7 to 61a86f1 Compare August 12, 2024 12:10
@Gottox Gottox force-pushed the fix/32bit-build branch 3 times, most recently from 17099d7 to 94799c3 Compare August 12, 2024 15:39
Copy link

sonarqubecloud bot commented Aug 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
10 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Gottox Gottox merged commit a1d880f into main Aug 12, 2024
18 checks passed
@Gottox Gottox deleted the fix/32bit-build branch August 18, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant