Fix appending rnd
query parameter to URLs in benchmark-server-timing
#165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
benchmark-server-timing
on a URL I was seeing the expected results:However, when I tried adding a query parameter then I found the Success Rate to be 0%:
I thought this was a problem in Optimization Detective but no, it happens when there is any query param:
The problem is that the
rnd
query parameter is being added by appending?rnd=...
to the URL without accounting for whether there are existing query parameters in the URL. This fixes that problem, while also usingMath.random()
rather than an auto-incremented number. These changes had previously been done forbenchmark-web-vitals
in #60.With the changes in this PR:
And:
And: