Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pipeThrough error and track API changes #752

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from

Conversation

aboba
Copy link

@aboba aboba commented Nov 5, 2021

The current sample throws when attempting to send over a uni-directional stream.

@google-cla
Copy link

google-cla bot commented Nov 5, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jeffposnick
Copy link
Contributor

R: @bashi and @yutakahirano

Copy link
Contributor

@bashi bashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@google-cla
Copy link

google-cla bot commented Nov 11, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jeffposnick
Copy link
Contributor

Thank you, @aboba & co.! If you could follow the CLA steps outlined in #752 (comment) I'll get this merged.

@beaufortfrancois beaufortfrancois force-pushed the gh-pages branch 7 times, most recently from c198a70 to 03c4155 Compare November 26, 2022 06:50
@beaufortfrancois beaufortfrancois force-pushed the gh-pages branch 5 times, most recently from 1de1b35 to c4f3954 Compare October 16, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants