WritableStream Example #532
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I actually do need a review because I need code examples for MDN. I tried to add Jake as the reviewer, but he isn't in the assignees list for some reason. |
|
@jakearchibald Do you mind having a look at this sample? |
beaufortfrancois
force-pushed
the
gh-pages
branch
7 times, most recently
from
c198a70 to
03c4155
Compare
beaufortfrancois
force-pushed
the
gh-pages
branch
5 times, most recently
from
1de1b35 to
c4f3954
Compare
markafoltz
approved these changes
Oct 28, 2024
| let buffer = new ArrayBuffer(2); | ||
| let view = new Uint16Array(buffer); | ||
| view[0] = chunk; | ||
| let decoded = decoder.decode(view, {stream: true}); |
There was a problem hiding this comment.
Can these variables be const?
| @@ -0,0 +1,8 @@ | |||
| <!-- TODO: Replace PLACEHOLDER with feature name. --> | |||
There was a problem hiding this comment.
Can you remove these TODOs?
Suggested change
| <!-- TODO: Replace PLACEHOLDER with feature name. --> |
| <!-- TODO: Replace PLACEHOLDER with feature name. --> | ||
| Stream Samples | ||
| === | ||
| <!-- TODO: Replace PLACEHOLDER in the path to correspond to the real github.io URL. --> |
There was a problem hiding this comment.
Suggested change
| <!-- TODO: Replace PLACEHOLDER in the path to correspond to the real github.io URL. --> |
| <!-- TODO: Replace PLACEHOLDER in the path to correspond to the real github.io URL. --> | ||
| See https://googlechrome.github.io/samples/streams/index.html for a live demo. | ||
|
|
||
| <!-- TODO: Replace PLACEHOLDER with the id from the chromestatus.com URL. --> |
There was a problem hiding this comment.
Suggested change
| <!-- TODO: Replace PLACEHOLDER with the id from the chromestatus.com URL. --> |
Comment on lines
+11
to
+14
| let buffer = new ArrayBuffer(2); | ||
| let view = new Uint16Array(buffer); | ||
| view[0] = chunk; | ||
| let decoded = decoder.decode(view, {stream: true}); |
There was a problem hiding this comment.
Suggested change
| let buffer = new ArrayBuffer(2); | |
| let view = new Uint16Array(buffer); | |
| view[0] = chunk; | |
| let decoded = decoder.decode(view, {stream: true}); | |
| const buffer = new ArrayBuffer(2); | |
| const view = new Uint16Array(buffer); | |
| view[0] = chunk; | |
| const decoded = decoder.decode(view, {stream: true}); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this is good enough for our samples, I'm going to try. At least I'll learn better coding.