-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook Archive 2.0 #13
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -0,0 +1,50 @@ | |||
<!DOCTYPE html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This component attempts to be the "theme editor" if you will. Meta tags, page title, colour scheme, and fonts are all defined here as the developer may wish.
When sorting old to new is it using the start of the finished date? |
In both cases (OLD to NEW and NEW to OLD), the sorting is based on start date. Your oldest notebook is the one you started first, even if you're still using it and others have been completed. |
const { condition } = Astro.props as { condition: boolean } | ||
--- | ||
{ | ||
condition && <slot/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha the best 😝
Ok so a pretty big update in terms of code, but I'll give you the spark notes:
The main fix here is switching to Astro as the base framework. I've come up with a new system for adding and organizing the notebooks, allowing them to be loaded automatically (and with all their metadata, like start/complete dates). I'll update the README to explain this process better.
Other than that, I've re-written everything from scratch, checking off most of the issues listed above. I'm not sure exactly how you can browse the update (other than cloning the branch and running locally) — the Vercel build is not configured to build the preview branch given this new set up. In leu of that, here are some comparisons in terms of the page design:
Old homepage vs New homepage
With the 3rd notebook hovered:
Old notebook page vs New notebook page
On page zero (aka, the cover):
Old mobile-sized notebook page vs New mobile-sized notebook page
Ongoing, todos, and regressions
These code changes remove some of the previous functionality of the site (#9), which we may or may not wish to re-implement (#10, #11) . As well, there continue to be things I'd like to add that this does not address (#6), and new issues these changes create (#12).