Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ Refactor/myParticipatedTeamBoxComponent [λ‚˜μ˜ μ°Έμ—¬ 기둝 νŒ€λ°•μŠ€ API μž¬μ—°κ²°] #298

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

πŸ”€ Refactor/myParticipatedTeamBoxComponent [λ‚˜μ˜ μ°Έμ—¬ 기둝 νŒ€λ°•μŠ€ API μž¬μ—°κ²°] #298

wants to merge 1 commit into from

Conversation

sxxcxng
Copy link
Collaborator

@sxxcxng sxxcxng commented Oct 7, 2024 •
edited
Loading

PR ν…œν”Œλ¦Ώ

체크리슀트!

  • πŸ”€ PR 제λͺ©μ˜ ν˜•μ‹μ„ 잘 μž‘μ„±ν–ˆλ‚˜μš”?
  • 🧹 λΆˆν•„μš”ν•œ μ½”λ“œλŠ” μ œκ±°ν–ˆλ‚˜μš”?
  • πŸ’­ μ΄μŠˆλŠ” λ“±λ‘ν–ˆλ‚˜μš”?
  • 🏷️ 라벨은 λ“±λ‘ν–ˆλ‚˜μš”?

μž‘μ—… λ‚΄μ—­

[λ‚˜μ˜ μ°Έμ—¬ 기둝 νŒ€λ°•μŠ€]

  1. ν™œλ™ 쀑 / ν™œλ™ μ™„λ£Œ μ»΄ν¬λ„ŒνŠΈ API μž¬μ—°κ²°
  2. μ§€μ›νŒŒνŠΈ API μž¬μ—°κ²°
  3. ν™œλ™ 쀑 -> bordercolor νŒŒλž€μƒ‰ / ν™œλ™ μ™„λ£Œ -> bordercolor 검정색 ... μˆ˜μ •

ν”Όλ“œλ°±μ„ λ°›κ³  싢은 λΆ€λΆ„

[λ‚˜μ˜ μ°Έμ—¬ 기둝 νŒ€λ°•μŠ€]

  1. ν™œλ™ 쀑 / ν™œλ™ μ™„λ£Œκ°€ μ•Œλ§žκ²Œ λœ¨λŠ”μ§€ ν™•μΈν•΄μ£Όμ„Έμš”.
  2. 1번의 상황에 따라 νŒ€λ°•μŠ€ ν…Œλ‘λ¦¬μƒ‰μ΄ 각각 νŒŒλž€μƒ‰ / κ²€μ •μƒ‰μœΌλ‘œ λœ¨λŠ”μ§€ ν™•μΈν•΄μ£Όμ„Έμš”.
  3. 1개의 μ§€μ›νŒŒνŠΈκ°€ μ•Œλ§žκ²Œ λœ¨λŠ”μ§€ ν™•μΈν•΄μ£Όμ„Έμš”.

PR 특이 사항

특이 사항 :

Issue Number: #296

close: #296

@sxxcxng
✏️ Fix participated teamBox component
d996bda 
#296 λ‚˜μ˜ 참여기둝 νŒ€λ°•μŠ€ μ»΄ν¬λ„ŒνŠΈ μˆ˜μ •
@sxxcxng sxxcxng added πŸ™†πŸ»β€β™€οΈ κ΅¬ν˜„ μ™„λ£Œ Improvements or additions to documentation β™»οΈλ¦¬νŒ©ν† λ§ λ¦¬νŒ©ν† λ§ 쀑 labels Oct 7, 2024
@sxxcxng sxxcxng self-assigned this Oct 7, 2024
sseuldev
sseuldev reviewed Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@sseuldev sseuldev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

λ‚˜μ˜ μ°Έμ—¬ κΈ°λ‘μ—μ„œ νŒ€μž₯의 κ²½μš°μ—λŠ”, νŒ€λ°•μŠ€μ˜ 지원뢄야λ₯Ό μ—†μ• λŠ” 걸둜 λ³€κ²½ λΆ€νƒλ“œλ €μš©~!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sseuldev sseuldev sseuldev left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@sxxcxng sxxcxng

Labels
β™»οΈλ¦¬νŒ©ν† λ§ λ¦¬νŒ©ν† λ§ 쀑 πŸ™†πŸ»β€β™€οΈ κ΅¬ν˜„ μ™„λ£Œ Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sxxcxng @sseuldev