Dont remove pendingAmountRemaining from donations

related to Giveth/feathers-giveth#432 it was a mistake the we were deleting pendingAmountRemaining
Giveth · May 12, 2021 · 5dc7c95 · 5dc7c95
1 parent 6aae9af
commit 5dc7c95
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 32 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -28,7 +28,6 @@ import {
   addCommitTimeForToApproveDonations,
   fetchDonationsInfo,
   fixConflictInDonations,
-  unsetPendingAmountRemainingFromCommittedDonations
 } from "./services/donationService";
 import {isReturnTransfer} from "./utils/donationUtils";
 import {report} from "./utils/reportUtils";
@@ -770,7 +769,6 @@ const main = async () => {
         //     events
         //   }
         // );
-        await unsetPendingAmountRemainingFromCommittedDonations();
         console.table(report);
         console.log('end of simulation ', new Date())
         if (config.get('emailReport')) {

diff --git a/src/services/donationService.ts b/src/services/donationService.ts
@@ -78,28 +78,6 @@ export async function fetchDonationsInfo():
 }
 
 
-export async function unsetPendingAmountRemainingFromCommittedDonations() {
-  const query = {
-    status: {$ne: DonationStatus.PENDING},
-    pendingAmountRemaining: {$exists: true}
-  };
-  const notPendingDonationsWithPendingAmountRemaining = await donationModel.find(query);
-  report.removedPendingAmountRemainingCount = notPendingDonationsWithPendingAmountRemaining.length;
-  console.log('Removed pendingAmountFromDonations count', notPendingDonationsWithPendingAmountRemaining.length)
-  notPendingDonationsWithPendingAmountRemaining.forEach(donation => {
-    logger.error('Remove pendingAmountFromDonations', {
-      _id: donation._id,
-      pendingAmountRemaining: donation.pendingAmountRemaining
-    })
-  })
-  await donationModel.updateMany(query, {
-    $set: {updatedBySimulationDate: new Date()},
-    $unset: {pendingAmountRemaining: 1}
-  })
-
-
-}
-
 export async function fixConflictInDonations(
   options: {
     unusedDonationMap: Map<string, any>,

diff --git a/src/services/emailService.ts b/src/services/emailService.ts
@@ -86,10 +86,6 @@ export const sendReportEmail = async (reportData: ReportInterface) => {
                   <td style='${tableCellStyle}'>createdPledgeAdmins count</td>
                   <td style='${tableCellStyle}'>${reportData.createdPledgeAdmins}</td>
                 </tr>
-                <tr>
-                  <td style='${tableCellStyle}'>removedPendingAmountRemainingCount</td>
-                  <td style='${tableCellStyle}'>${reportData.removedPendingAmountRemainingCount}</td>
-                </tr>
               </table>
       `,
       // cta: `Manage Milestone`,
@@ -109,8 +105,7 @@ export const sendReportEmail = async (reportData: ReportInterface) => {
       reportData.createdPledgeAdmins ||
       reportData.updateAmountRemaining ||
       reportData.updatedDonations ||
-      reportData.deletedDonations ||
-      reportData.removedPendingAmountRemainingCount
+      reportData.deletedDonations
     )
     const summaryMessage = resolvedConflicts ?
       'There were some conflicts that resolved' :

diff --git a/src/utils/interfaces.ts b/src/utils/interfaces.ts
@@ -112,7 +112,6 @@ export interface ReportInterface {
   fetchedNewPledgeCount: number,
   fetchedNewPledgeAdminCount: number,
   fetchedNewEventsCount: number,
-  removedPendingAmountRemainingCount: number,
 }
 
 export interface Token {

diff --git a/src/utils/reportUtils.ts b/src/utils/reportUtils.ts
@@ -20,5 +20,4 @@ export const report = {
   fetchedNewEventsCount: 0,
   fetchedNewPledgeAdminCount: 0,
   fetchedNewPledgeCount: 0,
-  removedPendingAmountRemainingCount: 0
 };