Install a specific CodeQL version. #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
ci/installcodeql
branch
3 times, most recently
from
08b7eb7 to
f9138c7
Compare
michaelnebel
force-pushed
the
ci/installcodeql
branch
from
cf4e34b to
54132d4
Compare
pwntester
approved these changes
Dec 13, 2024
|
Sounds good to me. If there are issues we can monitor them |
GeekMasher
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we add an action for downloading and caching a specific version of the CodeQL CLI instead of using what is in the tool cache. I ran into some issues with code suddenly not compiling when new CodeQL versions were picked up from the tool cache - so maybe we should consider to pin the CodeQL version? If not, we could also modify these workflows to download the latest CodeQL CLI instead.
Also we get all sorts of warnings during package install (subsequent steps) using the codeql in the tool cache (I think this is because the tool cache contains the entire bundle).
If we decide to use this "new" action, both the hotspots and publish workflows also needs to be updated.