Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new events for AI typing indicator #3516

Merged
merged 12 commits into from
Dec 2, 2024
Merged

Conversation

martinmitrevski
Copy link
Contributor

🔗 Issue Links

https://linear.app/stream/issue/AI-3/customnew-event-for-handling-message-streaming

🎯 Goal

Expose the new events that are going to be used for the AI integration.

📝 Summary

Provide bullet points with the most important changes in the codebase.

🛠 Implementation

Provide a detailed description of the implementation and explain your decisions if you find them relevant.

🎨 Showcase

Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.

Before After
img img

🧪 Manual Testing Notes

Explain how this change can be tested manually, if applicable.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

🎁 Meme

Provide a funny gif or image that relates to your work on this pull request. (Optional)

@martinmitrevski martinmitrevski requested a review from a team as a code owner November 29, 2024 16:17
@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamChat 7.06 MB 7.08 MB +20 KB 🟢
StreamChatUI 4.96 MB 4.96 MB 0 KB 🟢

Copy link

1 Warning
⚠️ Please be sure to complete the Contributor Checklist in the Pull Request description
1 Message
📖 There seems to be app changes but CHANGELOG wasn't modified.
Please include an entry if the PR includes user-facing changes.
You can find it at CHANGELOG.md.

Generated by 🚫 Danger

@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Nov 29, 2024

SDK Performance

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 6.68 ms 33.2% 🔼 🟢
Duration 2.6 s 2.55 s 1.92% 🔼 🟢
Hitch time ratio 4 ms per s 2.62 ms per s 34.5% 🔼 🟢
Frame rate 75 fps 78.38 fps 4.51% 🔼 🟢
Number of hitches 1 0.6 40.0% 🔼 🟢

Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment, other than that LGTM 👍

@nuno-vieira
Copy link
Member

@martinmitrevski Lets re-run the performance checks, just to make sure it is false positive.

@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Dec 2, 2024

SDK Size

title develop branch diff status
StreamChat 7.06 MB 7.08 MB +21 KB 🟢
StreamChatUI 4.96 MB 4.96 MB 0 KB 🟢

Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@martinmitrevski martinmitrevski merged commit 11cbd2e into develop Dec 2, 2024
14 checks passed
@martinmitrevski martinmitrevski deleted the ai/new-typing-events branch December 2, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants