Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Bump Xcode version #3509

Merged
merged 30 commits into from
Dec 3, 2024
Merged

[CI] Bump Xcode version #3509

merged 30 commits into from
Dec 3, 2024

Conversation

testableapple
Copy link
Contributor

@testableapple testableapple commented Nov 27, 2024 •
edited
Loading

🔗 Issue Links

https://linear.app/stream/issue/IOS-12/

🧪Testing Notes

✅ Cron checks

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@testableapple testableapple added the 🤖 CI/CD Any work related to CI/CD label Nov 27, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

2 Errors
🚫 Please use more than one word.
0fbb926
🚫 Please use more than one word.
9d5a0a3

Generated by 🚫 Danger

@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Nov 27, 2024 •
edited
Loading

SDK Size

title develop branch diff status
StreamChat 7.06 MB 6.96 MB -101 KB 🚀
StreamChatUI 4.96 MB 4.77 MB -198 KB 🚀

@testableapple testableapple marked this pull request as ready for review November 28, 2024 20:46
@testableapple testableapple requested a review from a team as a code owner November 28, 2024 20:46
@Stream-SDK-Bot
Copy link
Collaborator

SDK Performance

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 3.34 ms 66.6% 🔼 🟢
Duration 2.6 s 2.54 s 2.31% 🔼 🟢
Hitch time ratio 4 ms per s 1.31 ms per s 67.25% 🔼 🟢
Frame rate 75 fps 78.17 fps 4.23% 🔼 🟢
Number of hitches 1 0.4 60.0% 🔼 🟢

@testableapple testableapple enabled auto-merge (squash) November 28, 2024 21:34
laevandus
laevandus reviewed Nov 29, 2024
View reviewed changes
.github/workflows/smoke-checks.yml
env:
XCODE_VERSION: "14.0.1"
XCODE_VERSION: "15.0.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking why not 15.4, but I guess because App Store accepts all the Xcode 15 versions

laevandus
laevandus reviewed Nov 29, 2024
View reviewed changes
.github/workflows/smoke-checks.yml
timeout-minutes: 60
timeout-minutes: 120
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, I do have seen this timeout taking my run down

@laevandus
Copy link
Contributor

Looks good, although I not fully sure why all the snapshot tests were updated. I guess some shade of a color changed fractionally.

@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Nov 29, 2024 •
edited
Loading

SDK Size

title develop branch diff status
StreamChat 7.08 MB 6.98 MB -101 KB 🚀
StreamChatUI 4.96 MB 4.77 MB -198 KB 🚀

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
168 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.7% Coverage on New Code
0.1% Duplication on New Code

See analysis details on SonarQube Cloud

nuno-vieira
nuno-vieira reviewed Nov 29, 2024
View reviewed changes
TestTools/StreamChatTestTools/Mocks/StreamChat/Controllers/ChatChannelController_Mock.swift
@@ -5,20 +5,20 @@
import Foundation
@testable import StreamChat

public class ChatChannelController_Mock: ChatChannelController {
Copy link
Member

@nuno-vieira nuno-vieira Nov 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure this won't break anything? @laevandus We do have customers using this. I wonder if, even with testable import this could break some customers 🤔 We should try to test this branch on SwiftUI to make sure it does not break the tests

laevandus
laevandus approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@laevandus laevandus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but please add changelog entry about the test tools.

@testableapple testableapple merged commit 632b42b into develop Dec 3, 2024
8 of 12 checks passed
@testableapple testableapple deleted the ci/xcode-16 branch December 3, 2024 11:15
testableapple added a commit that referenced this pull request Dec 3, 2024
@testableapple
[CI] Bump Xcode version (#3509)
88c724b
@laevandus laevandus mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuno-vieira nuno-vieira nuno-vieira approved these changes

@laevandus laevandus laevandus approved these changes

Assignees
No one assigned
Labels
🤖 CI/CD Any work related to CI/CD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@testableapple @Stream-SDK-Bot @laevandus @nuno-vieira