-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Polls UI Components + Introducing View Container Builder #3435
Conversation
SDK Size
|
SDK Performance
|
Generated by 🚫 Danger |
SDK Size
|
* Introduce new ViewContainerBuilder * Add PollAttachmentView component * Change to SwiftUI ENV * Add `shouldShowOnlineIndicator` to turn off online presence in `ChatUserAvatarView` * Fix small iOS 13 deprecation * Add domain logic helpers to Poll * Message Polls live updates * Event.ownVotes workaround (Drop when fixed) * Manage data races when voting on a poll in the message list * Add haptic feedback when voting * Make sure to update the latestVotes author avatar views * Improve performance of Option List View by no recreating the item views everytime * Improve flexibility of Option List View without compromising performance * Make content of StackedUserAvatarsView public * Re-structure Common Buttons Folder * Add `CheckboxButton` as a common view * Add vote ratio logic to `ChatChannelListItemView` * Fix UI Glitches for option list item view when text is too big and avatar appears and disappears * Extract more common logic to `Poll` domain model * Add closed poll and winner option state logic * Add subtitle text logic to `PollAttachmentView` * Change winner logic to be the one and only one option with most votes * Add channel list message preview text for polls * Add poll quoted message text rendering * Add View Results and End Button to the Poll Attachment View * Fix poll option label width ui glitch * Added End Poll functionality * Add isOptionWinner and isOptionOneOfTheWinners to Poll * Fix message with Polls not showing when long pressing * Fix poll controller with incorrect data in message list * Sort the `latestVotes` and `latestAnswers` in the LLC * Add test coverage to Poll domain helpers * Add Test Coverage to Poll Message Preview in Channel List * Add test coverage to PollAttachmentView * Add test coverage to disabling online indicator in ChatUserAvatarView * Add test coverage to quoted poll * Fix some existing snapshot tests * Use UIStackView for Spacer() to avoid drawing * Fix Xcode 14 Build * Fix Poll AttachmentView Tests on CI * Update CHANGELOG.md * Update CHANGELOG.md * Fix Xcode 14 Build, conflict with SwiftUI Spacer * Revert "Change to SwiftUI ENV" This reverts commit 6d9129a. * Add documentation to ViewContainerBuilder * Fix vale issues * Fix using pin() instead of constraint() in docs
* Refactor PollResultsVC Section views to be more simple and flat hierarchy * Fix bottom spacing in Poll Results Section Header * Add comment buttons to `PollAttachmentView` * Add comment to poll implementation * Fix `poll.latestAnswers` being reset after poll event did not retreive the `latestAnswers` data We should not treat optional `latestAnswers` as empty, since they have different meanings * Add `PollCommentListVC` implementation * Fix `PollVoteListQueryDTO.filterHash` using filterHash only instead of queryHash This was causing the pollId to not be considered when fetching the DB votes * Make diffable data sources more stable * Fix first page of poll vote list resetting all votes * Fix the default vote list sorting * Add poll suggestions feature * Add anonymous polls support * Fix AlertsRouter docs * Add test coverage to `PollCommentListVC` * Add test coverage when poll comments are 0 * Add test coverage to allow suggestions * Add test coverage to anonymous polls * Re-record snapshots after renaming test file * Fix snapshot on CI * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update Sources/StreamChatUI/ChatMessageList/Attachments/Poll/PollAttachmentView.swift * Update Sources/StreamChatUI/ChatMessageList/Attachments/Poll/PollCommentListVC/PollCommentListSectionFooterView.swift * Fix comments and suggestion buttons showing when poll is closed * Update CHANGELOG.md * Change alert titles to follow Apples guideline * Improve comments view spacing * Optimize a bit to check if a user has already a comment
* [Polls] Add `PollAttachmentView` + `ViewContainerBuilder` (#3374) * Introduce new ViewContainerBuilder * Add PollAttachmentView component * Change to SwiftUI ENV * Add `shouldShowOnlineIndicator` to turn off online presence in `ChatUserAvatarView` * Fix small iOS 13 deprecation * Add domain logic helpers to Poll * Message Polls live updates * Event.ownVotes workaround (Drop when fixed) * Manage data races when voting on a poll in the message list * Add haptic feedback when voting * Make sure to update the latestVotes author avatar views * Improve performance of Option List View by no recreating the item views everytime * Improve flexibility of Option List View without compromising performance * Make content of StackedUserAvatarsView public * Re-structure Common Buttons Folder * Add `CheckboxButton` as a common view * Add vote ratio logic to `ChatChannelListItemView` * Fix UI Glitches for option list item view when text is too big and avatar appears and disappears * Extract more common logic to `Poll` domain model * Add closed poll and winner option state logic * Add subtitle text logic to `PollAttachmentView` * Change winner logic to be the one and only one option with most votes * Add channel list message preview text for polls * Add poll quoted message text rendering * Add View Results and End Button to the Poll Attachment View * Fix poll option label width ui glitch * Added End Poll functionality * Add isOptionWinner and isOptionOneOfTheWinners to Poll * Fix message with Polls not showing when long pressing * Fix poll controller with incorrect data in message list * Sort the `latestVotes` and `latestAnswers` in the LLC * Add test coverage to Poll domain helpers * Add Test Coverage to Poll Message Preview in Channel List * Add test coverage to PollAttachmentView * Add test coverage to disabling online indicator in ChatUserAvatarView * Add test coverage to quoted poll * Fix some existing snapshot tests * Use UIStackView for Spacer() to avoid drawing * Fix Xcode 14 Build * Fix Poll AttachmentView Tests on CI * Update CHANGELOG.md * Update CHANGELOG.md * Fix Xcode 14 Build, conflict with SwiftUI Spacer * Revert "Change to SwiftUI ENV" This reverts commit 6d9129a. * Add documentation to ViewContainerBuilder * Fix vale issues * Fix using pin() instead of constraint() in docs * [Polls] Add `PollResultsVC` (#3381) * [Polls] Comments + Suggestions + Anonymous Polls + LLC Fixes (#3398) * Refactor PollResultsVC Section views to be more simple and flat hierarchy * Fix bottom spacing in Poll Results Section Header * Add comment buttons to `PollAttachmentView` * Add comment to poll implementation * Fix `poll.latestAnswers` being reset after poll event did not retreive the `latestAnswers` data We should not treat optional `latestAnswers` as empty, since they have different meanings * Add `PollCommentListVC` implementation * Fix `PollVoteListQueryDTO.filterHash` using filterHash only instead of queryHash This was causing the pollId to not be considered when fetching the DB votes * Make diffable data sources more stable * Fix first page of poll vote list resetting all votes * Fix the default vote list sorting * Add poll suggestions feature * Add anonymous polls support * Fix AlertsRouter docs * Add test coverage to `PollCommentListVC` * Add test coverage when poll comments are 0 * Add test coverage to allow suggestions * Add test coverage to anonymous polls * Re-record snapshots after renaming test file * Fix snapshot on CI * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update Sources/StreamChatUI/ChatMessageList/Attachments/Poll/PollAttachmentView.swift * Update Sources/StreamChatUI/ChatMessageList/Attachments/Poll/PollCommentListVC/PollCommentListSectionFooterView.swift * Fix comments and suggestion buttons showing when poll is closed * Update CHANGELOG.md * Change alert titles to follow Apples guideline * Improve comments view spacing * Optimize a bit to check if a user has already a comment * Add poll creation action to composer if polls are enabled * Add Poll Creation Views and UX * Handle keyboard adjustment in the poll creation view * Add actual if-statement support to ViewContainerBuilder * Add Poll Creation View Styling * Add poll creation section header view * Add Poll Creation Feature Cell Styling * Add Multiple Votes Feature Cell Data handling * Improve data handling in PollCreationVC * Add poll creation button * Fix Poll Creation Memory Leaks + Add Poll Option Errors * Implement poll option error indices * Refactor Poll Creation View to Collection View * Add views to components and appearance * Implement keyboard management in Poll Creation VC * Implementation of discarding poll changes * Add poll alert error if creation fails * Fix basic features not being persisted * Add localization to the views * Add for polls feature support configuration * Add Poll Creation View test coverage * Update CHANGELOG.md * Fix test_canCreatePoll_whenOptionsError_shouldReturnFalse test * [CI] Snapshots (#3434) Co-authored-by: Stream Bot <[email protected]> * Fix maximum votes error not being cleared when multiple votes is disabled * Change multiple votes keyboard to number bad * Remove custom equatable implementation that is not required for PollFeatureType * Remove yeetd-normal.pkg file? * Fix adding duplicate options * Disable swiftlint notification_center_detachment and switch_case_alignment * Extract poll creation input view height to a constant --------- Co-authored-by: Stream SDK Bot <[email protected]> Co-authored-by: Stream Bot <[email protected]>
… `layout` and `constraints` The layout and constraints function would not work at all because applying constraints before adding a view to hierarchy is not possibl.e
…g them to poll.latestVotes
7b7b295
to
45c52be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of questions:
- Did you test if everything works well in SwiftUI with this branch?
- Why not include the polls docs in this PR?
Sources/StreamChatUI/ChatMessageList/Attachments/Poll/PollCreationVC/PollCreationVC.swift
Show resolved
Hide resolved
Sources/StreamChatUI/Utils/KeyboardHandler/DefaultScrollViewKeyboardHandler.swift
Outdated
Show resolved
Hide resolved
0ae3379
to
12aa799
Compare
Co-authored-by: Stream Bot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That weird yeetd-normal.pkg file appeared again, please remove it. Other than that, looks good to me.
Quality Gate passedIssues Measures |
🔗 Issue Links
Resolves https://stream-io.atlassian.net/browse/PBE-4287
🎯 Goal
Adds Poll UIKit components and introduces the new View Container Builder.
📝 Summary
This is the final PR that groups the following PRs:
Additionally:
PollAllOptionsListVC
componentpoll.latestAnswers
andpoll.ownVotes
were impacting each other, causing the "Add a comment" button to disappear when adding a regular vote. (There was an attempt to fix this here but it did not fix 100%)layout {}
andconstraints {}
from ViewContainerBuilder since adding constraints before the view hierarchy is not possiblepadding()
helper to ViewContainerBuilderFeatures Missing:- The only thing missing, which will be out of scope for now, is the limit of 10 options for each Poll in the message list, plus the additional view to see all the votes.🛠 Implementation
Below is the summary of all the components added.
PollAttachmentView
PollResultsVC
PollResultsVoteListVC
PollCommentListVC
PollCreationVC
PollAllOptionsListVC
🎨 Showcase
Quick demo of the main features:
Simulator.Screen.Recording.-.iPhone.15.Pro.17.4.-.2024-09-26.at.23.21.54.mov
🧪 Manual Testing Notes
Poll Creation View
Things to test:
Message Poll Attachment View
Things to test:
Poll Comments
Things to test:
Poll Results
Things to test:
Channel List Message Previews (When last message is a poll)
Things to test:
Quoting a Poll
Things to test:
☑️ Contributor Checklist