Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix handling of ParsedHTMLString in html() and html!() #688

Merged
merged 2 commits into from
Nov 9, 2023
Merged

fix handling of ParsedHTMLString in html() and html!() #688

merged 2 commits into from
Nov 9, 2023

Conversation

hhaensel
Copy link
Member

@hhaensel hhaensel commented Nov 9, 2023

Currently, routing of ParsedHTMLString is broken in two ways:

  • ParsedHTMLValues and vectors thereof are not correctly handled by html(); layout and model are ignored
  • content of functions that generate ParsedHTML or vectors thereof is parsed; it is therefore impossible to route content that is not correctly parsed, e.g. '@' characters (cf. @click handler doesn't work v-on:click works Stipple.jl#164)

This PR fixes both shortcomings. There'll be a respective PR in Stipple.

@hhaensel
Copy link
Member Author

hhaensel commented Nov 9, 2023

still needs a fix ...

@hhaensel
Copy link
Member Author

hhaensel commented Nov 9, 2023 •
edited
Loading

Ready for review, as well as GenieFramework/Stipple.jl#239 ...

@essenciary essenciary merged commit 8191f10 into GenieFramework:master Nov 9, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@essenciary essenciary Awaiting requested review from essenciary

@AbhimanyuAryan AbhimanyuAryan Awaiting requested review from AbhimanyuAryan

@PGimenez PGimenez Awaiting requested review from PGimenez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hhaensel @essenciary